[Bugfix] Eror messages from Zou would not be returned properly #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…given under errors instead of message.
|
Thank you for this addition. @EvanBldy we have to make Zou error message more consistent. |
|
I saw the check for Python 2.7 fail. This is most likely caused by the type hinting that I added. Given that 2.7 reached EOL in 2020, and that current versions of Maya also switched to Python3, I'm not really a big fan of supporting 2.7. That being said, I'll remove the type hinting to make all checks green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Zou returns json objects with the 'error' key instead of 'message'.
As an example; See https://github.com/cgwire/zou/blob/7f217f6be8cbc6eb1b10d80ca465c823b0aede40/zou/app/blueprints/files/resources.py#L705
Solution
I've added a utility function that checks a given request for the presence of both 'message' and 'error' keys, so that the error message of Zou can be properly passed on.
I also updated the UnitTests to test the following scenario's: verifying that the error message raised matches the one given by Zou and properly handling the error message when attempting to create a duplicate working file.